Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qfix] Fix labels naming in clientinfo #966

Merged
merged 1 commit into from
Jun 7, 2021
Merged

[qfix] Fix labels naming in clientinfo #966

merged 1 commit into from
Jun 7, 2021

Conversation

d-uzlov
Copy link
Contributor

@d-uzlov d-uzlov commented Jun 7, 2021

Description

Client info uses awkward names for the labels it adds, like nodeNameKey, which don't match label names from original proposal.
This PR fixes this.

Issue link

#892

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we expect to use

{{index .Src "nodeName"}}

@denis-tingaikin denis-tingaikin merged commit 2f37045 into networkservicemesh:main Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants